[tin-bugs] tin-2.4.5 SIGSEGV when clicking past the end of topic list in a newsgroup in mate-terminal

[Dominik 'Rathann' Mierzejewski]

(Cc'ing Urs as tin-bugs archives seem to contain only spam for the past
months)

Dear developers,

I accidentally clicked my mouse in the "empty" area past the end of the
topic list in newsgroup view in my X terminal (mate-terminal) and tin
crashed with SIGSEGV. Here's the backtrace:
#0  __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:120
#1  0x00007ffff7b642a8 in __vfprintf_internal (s=s at entry=0x7fffffffc9a0, format=format at entry=0x5555555f83ae "%s", 
    ap=ap at entry=0x7fffffffcb20, mode_flags=mode_flags at entry=2) at vfprintf-internal.c:1647
#2  0x00007ffff7b7516a in __vsnprintf_internal (string=string at entry=0x555555c4f670 "", maxlen=<optimized out>, 
    maxlen at entry=1024, format=format at entry=0x5555555f83ae "%s", args=args at entry=0x7fffffffcb20, 
    mode_flags=mode_flags at entry=2) at vsnprintf.c:114
#3  0x00007ffff7c05752 in ___vsnprintf_chk (s=s at entry=0x555555c4f670 "", maxlen=maxlen at entry=1024, flag=flag at entry=1, 
    slen=slen at entry=18446744073709551615, format=format at entry=0x5555555f83ae "%s", ap=ap at entry=0x7fffffffcb20)
    at vsnprintf_chk.c:34
#4  0x00005555555c7c46 in vsnprintf (__ap=0x7fffffffcb20, __fmt=0x5555555f83ae "%s", __n=1024, __s=0x555555c4f670 "")
    at /usr/include/bits/stdio2.h:83
#5  fmt_message (fmt=fmt at entry=0x5555555f83ae "%s", ap=ap at entry=0x7fffffffcb80) at ./screen.c:84
#6  0x00005555555c9039 in info_message (fmt=0x5555555f83ae "%s") at ./screen.c:116
#7  0x0000555555584320 in draw_subject_arrow () at ./group.c:986
#8  draw_subject_arrow () at ./group.c:977
#9  0x0000555555584220 in global_mouse_action (left_action=<optimized out>, right_action=0x55555558b660 <group_right>)
    at ./global.c:335
#10 0x000055555558b886 in group_page (group=<optimized out>) at ./group.c:208
#11 0x00005555555d2885 in read_groups () at ./select.c:1216
#12 0x00005555555d5671 in selection_page (start_groupnum=<optimized out>, num_cmd_line_groups=<optimized out>)
    at ./select.c:231
#13 0x000055555556b050 in main (argc=<optimized out>, argv=<optimized out>) at ./main.c:436

It's 100% reproducible. Open a newsgroup with unread articles (more than
one screen). Go to the end (I press "End" key) and click in the empty
area past the last topic.

I'm running Fedora 33 and tin from distribution repository.
$ tin -V
Version: tin 2.4.5 release 20201224 ("Glen Albyn") Jan  4 2021 00:00:00
Platform:
	OS-Name  = "linux-gnu"
Compiler:
	CC       = "gcc"
	CFLAGS   = "-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection"
	CPP      = "gcc -E"
	CPPFLAGS = "-D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600"
Linker and Libraries:
	LD       = "gcc"
	LDFLAGS  = "-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld"
	LIBS     = "-lpcre   -lncursesw -ltinfo  -lgsasl -licuuc"
	PCRE     = "8.44 2020-02-12"
Characteristics:
	-DEBUG +NNTP_ABLE -NO_POSTING -BROKEN_LISTGROUP +XHDR_XREF
	-HAVE_FASCIST_NEWSADMIN +ENABLE_IPV6 -HAVE_COREFILE
	-NO_SHELL_ESCAPE -DISABLE_PRINTING -DONT_HAVE_PIPING -NO_ETIQUETTE
	+HAVE_LONG_FILE_NAMES +APPEND_PID -HAVE_MH_MAIL_HANDLING
	+HAVE_ISPELL -HAVE_METAMAIL +HAVE_SUM
	+HAVE_COLOR -HAVE_PGP -HAVE_PGPK +HAVE_GPG
	+MIME_BREAK_LONG_LINES -MIME_STRICT_CHARSET +CHARSET_CONVERSION
	+MULTIBYTE_ABLE -NO_LOCALE -USE_LONG_ARTICLE_NUMBERS
	-USE_CANLOCK -EVIL_INSIDE -FORGERY -TINC_DNS -ENFORCE_RFC1034
	-REQUIRE_BRACKETS_IN_DOMAIN_LITERAL -ALLOW_FWS_IN_NEWSGROUPLIST

Regards,
Dominik
-- 
Fedora   https://getfedora.org  |  RPM Fusion  http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan