[tin-bugs] Error in compiling tin-2.6.2

[Brad Littlejohn]

	I’ll mention one more thing, as I just tried recompiling this in linux:

./nntplib.c: In function “get_tcp_socket”:
./nntplib.c:526:24: warning: implicit declaration of function “s_close"; did you mean “close”? [-Wimplicit-function-declaration]
./nntplib.c:526:24: warning: nested extern declaration of “s_close” {-Wnested-externs]

	Changing s_close() to close() on that line does result in a clean compile on both Linux and MacOS, but I am not sure if that is the right change to make, hence the post.

	BL.


> On Dec 28, 2022, at 3:23 PM, Brad Littlejohn <tyketto at sbcglobal.net> wrote:
> 
> 
> 	Hey all.
> 
> 	I am not on the mailing list, so I may not see any replies to this or if a fix for this has been committed.
> 
> 	Since tin-2.6.2 was in the beta/snapshot stage, I’ve been getting the following error when compiling it:
> 
> 
> bradl at MacBook-Air-3:~/tin-2.6.2/src> make
> gcc -DHAVE_CONFIG_H -I. -I../include -I../pcre -I../pcre  -DLOCALEDIR=\"/usr/local/share/locale\" -I../include   -D_DARWIN_C_SOURCE -D_CONST_X_STRING -O2 -Qunused-arguments -Wno-error=implicit-function-declaration  -W -Wall -Wbad-function-cast -Wcast-align -Wcast-qual -Wdeclaration-after-statement -Wextra -Winline -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wstrict-prototypes -Wundef -Wno-inline -Wwrite-strings -c ./nntplib.c
> ./nntplib.c:526:10: warning: implicit declaration of function 's_close' is invalid in C99 [-Wimplicit-function-declaration]
>                 (void) s_close(s);
> 
> 1 warning generated.
> Linking tin v2.6.2 ...
> gcc  -o ./tin  ./active.o ./art.o ./attrib.o ./auth.o ./charset.o ./color.o ./config.o ./cook.o ./curses.o ./debug.o ./envarg.o ./feed.o ./filter.o ./getline.o ./global.o ./group.o ./hashstr.o ./header.o ./help.o ./inews.o ./init.o ./joinpath.o ./keymap.o ./lang.o ./langinfo.o ./list.o ./lock.o ./mail.o ./main.o ./memory.o ./mimetypes.o ./misc.o ./my_tmpfile.o ./newsrc.o ./nntplib.o ./nntps.o ./nrctbl.o ./options_menu.o ./page.o ./parsdate.o ./pgp.o ./plp_snprintf.o ./post.o ./prompt.o ./read.o ./refs.o ./regex.o ./rfc1524.o ./rfc2045.o ./rfc2046.o ./rfc2047.o ./save.o ./screen.o ./search.o ./select.o ./sigfile.o ./signal.o ./strftime.o ./string.o ./tags.o ./tcurses.o ./tmpfile.o ./thread.o ./version.o ./wildmat.o ./xref.o -L../pcre -lpcre  -lcurses  -liconv 
> Undefined symbols for architecture arm64:
>   "_s_close", referenced from:
>       _nntp_open in nntplib.o
> ld: symbol(s) not found for architecture arm64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> make: *** [tin] Error 1
> 
> 	I’m using the following for compile options:
> 
> ./configure --with-gpg=/usr/local/bin/gpg --with-shell=/bin/bash --enable-nntp-only --enable-warnings --with-screen=terminfo --with-domain-name=<my domain here> --with-nntp-default-server=<MY NNTP SERVER HERE> --disable-ipv6 --with-coffee --disable-nls --with-included-gettext --with-Xaw3d --with-x
> 
> bradl at MacBook-Air-3:~> gcc -v
> Apple clang version 14.0.0 (clang-1400.0.29.202)
> Target: arm64-apple-darwin21.6.0
> Thread model: posix
> InstalledDir: /Library/Developer/CommandLineTools/usr/bin
> 	
> 	I get the same warning at compile time and error linking with both MacOS 12.6.1, as well as in linux, so I know it isn’t any changes to gcc or anything that would cause this. Additionally, tin-2.6.1 compiles cleanly. Any insights?
> 
> 	BL.
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.tin.org/pipermail/tin-bugs/attachments/20221228/6730d05e/attachment-0001.htm>