[tin-bugs] GnuTLS build fails without "--enable-debug"

[Anna (cybertailor) Vyalkova]

On 2023-01-14 09:53, Urs Janßen wrote:
> In <mailman.1282.1673682718.1791.tin-bugs at tin.org> on Sat, 14 Jan 2023 08:51:48,
>     Anna (cybertailor) Vyalkova wrote:
> > The problem is, necessary function definitions are hidden behind debug
> > ifdefs.
> 
> --- src/nntps.c	2022-12-09 10:03:48.461822133 +0100
> +++ src/nntps.c	2023-01-14 09:44:34.913637328 +0100
> @@ -41,8 +41,8 @@
>  #endif /* USE_LIBTLS */
>  
>  #ifdef USE_GNUTLS
> -#	ifdef DEBUG
>  static int verification_func(gnutls_session_t session);
> +#	ifdef DEBUG
>  static void log_func(int level, const char *msg);
>  #	endif /* DEBUG */
>  #else
> @@ -933,8 +933,7 @@
>  #endif /* USE_OPENSSL */
>  
>  
> -#ifdef DEBUG
> -#	ifdef USE_GNUTLS
> +#ifdef USE_GNUTLS
>  static int
>  verification_func(
>  	gnutls_session_t session)
> @@ -953,8 +952,11 @@
>  
>  	return gnutls_verification_status;
>  }
> +#endif /* USE_GNUTLS */
>  
>  
> +#ifdef DEBUG
> +#	ifdef USE_GNUTLS
>  static void
>  log_func(
>  	int level,

This patch fixes the problem. It will be included in the Gentoo package.

I'd also like to include signature verification support but no one
distro would carry PGP2 or GPG1 now. How about using also signify[1] or
minisign[2] for signing releases?

[1]: https://github.com/aperezdc/signify
[2]: https://github.com/jedisct1/minisign