[tin-dev] [tin 2.4.1] snapshots - please test

Urs Janßen urs at tin.org
Tue Dec 13 16:57:46 CET 2016


In <mailman.13.1480510699.4716.tin-dev at tin.org>, Urs Janßen wrote:
> I've made snapshots of the upcomming 2.4.1 release (planned for xmas),
> please give them a try and report (or even fix) any issues:

looks like -A was broken, the following patch should fix it. I'll
prepare new snapshost later today.

=== modified file 'src/auth.c'
--- src/auth.c	2016-10-12 15:40:33 +0000
+++ src/auth.c	2016-12-13 15:50:34 +0000
@@ -297,6 +297,12 @@
 				return TRUE;
 			}
 		}
+#   ifdef DEBUG
+		else {
+			if (debug & DEBUG_NNTP)
+				 debug_print_file("NNTP", "read_newsauth_file(\"%s\", \"%s\", \"%s\") failed", server, authuser, authpass);
+		}
+#   endif /* DEBUG */
 	}
 
 	/*

=== modified file 'src/nntplib.c'
--- src/nntplib.c	2016-11-30 12:49:26 +0000
+++ src/nntplib.c	2016-12-13 15:47:06 +0000
@@ -1451,17 +1451,18 @@
 			}
 			check_extensions();
 		}
+	}
 
-		if (force_auth_on_conn_open) {
+	if (force_auth_on_conn_open) {
 #	ifdef DEBUG
-			if (debug & DEBUG_NNTP)
-				debug_print_file("NNTP", "nntp_open() authenticate(force_auth_on_conn_open)");
+		if (debug & DEBUG_NNTP)
+			debug_print_file("NNTP", "nntp_open() authenticate(force_auth_on_conn_open)");
 #	endif /* DEBUG */
 
-			if (!authenticate(nntp_server, userid, FALSE))	/* 3rd parameter is FALSE as we need to get prompted for username password here */
-				return -1;
+		if (!authenticate(nntp_server, userid, FALSE))	/* 3rd parameter is FALSE as we need to get prompted for username password here */
+			return -1;
+		if (nntp_caps.type == CAPABILITIES)
 			check_extensions();
-		}
 	}
 
 	if ((nntp_caps.type == CAPABILITIES && nntp_caps.mode_reader) || nntp_caps.type != CAPABILITIES) {




More information about the tin-dev mailing list