[tin-dev] [tin-bugs] SIGSEGV in tin 2.4.4

[Urs Janßen]

On Thu, Jan 28, 2021 at 05:45:46PM +0000, Nigel Reed wrote:
> The article is on endofthelinebbs.com in the  Rmininet.RM_ANTI-VIRUS
> group.  (It's an nntp front end to my BBS groups.  The offending article
> has a blank subject line.

I can reproduce that, the problem is in fact the blank subject which is not
allowed in usenet articles, but sure tin shouldn't crash.

the following patch should fix that (but there might be other locations in
the code which do not expect an unset subject).

=== modified file 'src/post.c'
--- src/post.c	2021-01-04 02:02:43 +0000
+++ src/post.c	2021-01-28 21:34:44 +0000
@@ -3009,7 +3009,7 @@
 #endif /* FORGERY */
 	msg_add_header("From", from_name);
 
-	ptr = my_strdup(note_h.subj);
+	ptr = my_strdup(BlankIfNull(note_h.subj));
 	snprintf(bigbuf, sizeof(bigbuf), "Re: %s", eat_re(ptr, TRUE));
 	msg_add_header("Subject", bigbuf);
 	free(ptr);