[tin-dev] -C and timeout with low nntp_read_timeout_secs and huge group

Urs Janßen urs at tin.org
Wed Jul 19 23:34:23 CEST 2023


In <mailman.1673.1689743788.1791.tin-dev at tin.org> on Wed, 19 Jul 2023 07:16:26,
    I wrote:
> +#      ifdef USE_ZLIB
> +                       /*
> +                        * response compression from the server may take while
> +                        * when running interactively and not beeimg in the 
> +                        * connection phase give the user a change to go on
> +                        * instead of exiting
> +                        * TODO: strings to lang.c and incl. nntp_read_timeout_secs
> +                        */
> +                       if (signal_context == cReconnect || batch_mode || !use_compress || !nntp_caps.compress || prompt_yn(_("Read timeout from server - quit tin?"), FALSE) == 1)
> +#      endif /* USE_ZLIB */
> +                               tin_done(NNTP_ERROR_EXIT, _("NNTP connection error. Exiting..."));
> +#      ifdef USE_ZLIB
> +                       else {
> +                               RESTORE_HANDLER(sig, signal_handler);
> +                       }
> +#      endif /* USE_ZLIB */

this has issues with -zC as -z temporay sets batch_mode to skip some stuff

=== modified file 'src/main.c'
--- src/main.c	2023-06-26 16:39:10 +0000
+++ src/main.c	2023-07-19 21:32:49 +0000
@@ -399,12 +399,8 @@
 		tin_done(check_start_save_any_news(CHECK_ANY_NEWS, catchup), NULL);
 
 	if (start_any_unread) {
-		batch_mode = TRUE;			/* Suppress some unwanted on-screen garbage */
-		if ((start_groupnum = check_start_save_any_news(START_ANY_NEWS, catchup)) == -1) {
-			batch_mode = FALSE;
+		if ((start_groupnum = check_start_save_any_news(START_ANY_NEWS, catchup)) == -1)
 			tin_done(EXIT_SUCCESS, NULL);
-		}
-		batch_mode = FALSE;
 	}
 
 	/*



More information about the tin-dev mailing list