[tin-users] Piping/Printing message looks odd TODO

Urs Jan├čen urs at tin.org
Sat Mar 26 00:47:15 CET 2016


On Fri, Mar 25, 2016 at 01:55:03PM -0400, Glenn Spell wrote:
> Please take a look at this and tell me what y'all think:

instead of the goto I'd use

   if (!feeding) {
        /* If this is a new progress meter, start recalculating */
// ...
   } else
        snprintf(display, sizeof(display), "%s", txt);

and move the if (!feeding) block from the end up into that large block.

Otherwise it looks ok to me (but I didn't test it anywhere except
i686-pc-linux-gnu & ncursesw (6.0.20160319)).

urs



More information about the tin-users mailing list